PR #10: reachable freshness filter for /rag/search and /rag/top#10
PR #10: reachable freshness filter for /rag/search and /rag/top#10khalidsaidi merged 1 commit intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b5165bc3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const checkedAtRaw = (enrichment as any)?.reachableCheckedAt; | ||
| if (typeof checkedAtRaw !== 'string' || !checkedAtRaw) return false; |
There was a problem hiding this comment.
In passesFilters, the new freshness gate only reads enrichment.reachableCheckedAt, so records that still store reachability time under lastReachableAt are treated as missing and excluded whenever reachable=true&reachableMaxAgeHours=... is used. The codebase still treats lastReachableAt as a valid fallback elsewhere (for example, response mapping in apps/api/src/app.ts), so this creates false negatives for older-but-valid indexed data until those rows are rewritten.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
All checks passed locally.